davidradl commented on code in PR #167:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/167#discussion_r2077179015


##########
docs/content/docs/connectors/table/jdbc.md:
##########
@@ -38,12 +38,27 @@ The JDBC sink operate in upsert mode for exchange 
UPDATE/DELETE messages with th
 Dependencies
 ------------
 
+When using the JDBC connector, `flink-connector-jdbc-core`, 
`flink-connector-jdbc-${database}` and the JDBC driver needs to be added to the 
dependencies.

Review Comment:
   nit: needs -> need
   nit2:
   Is this accurate?
   If I want to connect to Derby I need the  `flink-connector-jdbc-core` and 
the Derby driver.
   If I want to connect to DB2 I need the Derby artifact 
`flink-connector-jdbc-core`and the DB2 driver. I assume I do not need the Derby 
driver.  
   
   It might be clearer to say something like. The `flink-connector-jdbc-core` 
contains core JDBC capability, it also has built in support for Derby. To use 
another database , you need to supply it's  `flink-connector-jdbc-${database}` 
from the same Flink JDBC connector release and the associated JDBC driver.  
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to