gyfora commented on code in PR #978:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/978#discussion_r2079138184


##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkDeploymentStatus.java:
##########
@@ -55,4 +55,7 @@ public class FlinkDeploymentStatus extends 
CommonStatus<FlinkDeploymentSpec> {
 
     /** Information about the TaskManagers for the scale subresource. */
     private TaskManagerInfo taskManager;
+
+    /** Information about when the last exception was recorded for this 
deployment. */
+    private String lastRecordedExceptionTimestamp;

Review Comment:
   As I wrote earlier, I don't think this should go in the status. This is a 
just an optimization that we can do on the operator side, caching the timestamp 
for the resource.
   
   The reason why this is important because status is part of the public api 
(CRD) changes like this are harder to roll out in general and have higher 
impact. It's also important to limit the size of the status to the reasonable 
minimum



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to