[
https://issues.apache.org/jira/browse/FLINK-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15775053#comment-15775053
]
ASF GitHub Bot commented on FLINK-5280:
---------------------------------------
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3039#discussion_r93816695
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSource.scala
---
@@ -26,24 +26,24 @@ import org.apache.flink.table.api.TableEnvironment
* Schema information consists of a data type, field names, and
corresponding indices of
* these names in the data type.
*
- * To define a TableSource one need to implement
[[TableSource.getReturnType]]. In this case
- * field names and field indices are deducted from the returned type.
+ * To define a TableSource one need to implement
[[TableSource#getReturnType]]. In this case
+ * field names and field indices are derived from the returned type.
*
* In case if custom field names are required one need to implement both
- * [[TableSource.getFieldsNames]] and [[TableSource.getFieldsIndices]].
+ * [[TableSource#getFieldsNames]] and [[TableSource#getFieldsIndices]].
*
* @tparam T The return type of the [[TableSource]].
*/
trait TableSource[T] {
/** Returns the names of the table fields. */
def getFieldsNames: Array[String] = {
- TableEnvironment.getFieldInfo(getReturnType)._1
+ TableEnvironment.getFieldNames(getReturnType)
}
/** Returns the indices of the table fields. */
- def getFieldsIndices: Array[Int] = {
- getFieldsNames.indices.toArray
+ def getFieldsIndexes: Array[Int] = {
--- End diff --
The plural of index should be indices.
> Extend TableSource to support nested data
> -----------------------------------------
>
> Key: FLINK-5280
> URL: https://issues.apache.org/jira/browse/FLINK-5280
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.2.0
> Reporter: Fabian Hueske
> Assignee: Ivan Mushketyk
>
> The {{TableSource}} interface does currently only support the definition of
> flat rows.
> However, there are several storage formats for nested data that should be
> supported such as Avro, Json, Parquet, and Orc. The Table API and SQL can
> also natively handle nested rows.
> The {{TableSource}} interface and the code to register table sources in
> Calcite's schema need to be extended to support nested data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
