beryllw commented on code in PR #3874:
URL: https://github.com/apache/flink-cdc/pull/3874#discussion_r2084204371
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/reader/BinlogSplitReader.java:
##########
@@ -257,6 +259,10 @@ private boolean shouldEmit(SourceRecord sourceRecord) {
// only the table who captured snapshot splits need to filter
if (finishedSplitsInfo.containsKey(tableId)) {
+ // if backfill skipped, don't need to filter
+ if (isBackfillSkipped) {
+ return true;
Review Comment:
Add MySQL test:
org.apache.flink.cdc.connectors.mysql.debezium.reader.BinlogSplitReaderTest#testSnapshotScanSkipBackfillWithPostHighWatermark
org.apache.flink.cdc.connectors.mysql.debezium.reader.BinlogSplitReaderTest#testSnapshotScanSkipBackfillWithPreHighWatermark
For MySQL(MySqlSourceITCase),Oracle(OracleSourceITCase.java),
SqlServer(SqlServerSourceITCase.java),
Mongodb(MongoDBFullChangelogITCase.java), and
Postgres(PostgresSourceITCase.java), these already have unit tests. If they are
not sufficient, I can supplement them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
