ferenc-csaky commented on PR #25218: URL: https://github.com/apache/flink/pull/25218#issuecomment-2872819736
> I missed that I was still tagged as waiting for review from my end. I'm sorry for that. I have a few nitty comments. > > Just one concern on the default value for the newly introduced parameter: Shouldn't we disable the feature still by default to have a stable behavior for the minor release (no behavioral change when upgrading the Flink version)? The user can enable the feature/bug fix by modifying the configuration parameter. WDYT? After the mailing list and PR conversation IMO the consensus is that minimizing TM number is desired in most use-cases, so I am leaning towards changing this option even though it's a patch release, and include some warning/details about it in the Release Notes. I would say most people do not read docs only if something do not work as they think it should, so I would prefer making it work as one would expect by default the most as we can. But I do not necessarily insist, if we decide to opt this out, we can still highlight to opt-in in the release notes, but back to base, most people won't read that anyways. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
