[
https://issues.apache.org/jira/browse/FLINK-5390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15778343#comment-15778343
]
ASF GitHub Bot commented on FLINK-5390:
---------------------------------------
GitHub user MayerRoman opened a pull request:
https://github.com/apache/flink/pull/3045
[FLINK-5390] [yarn] Fix for proper closing input and output streams, in
case of errors
[FLINK-5390] input should be closed in finally block in
YarnFlinkApplicationMasterRunner#loadJobGraph()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MayerRoman/flink FLINK-5390
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3045.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3045
----
commit 3e71b439908a2f89bac9542e249312036c652a4b
Author: Roman Maier <[email protected]>
Date: 2016-12-26T13:24:11Z
[FLINK-5390] [yarn] Fix for proper closing input and output streams, in
case of errors
----
> input should be closed in finally block in
> YarnFlinkApplicationMasterRunner#loadJobGraph()
> ------------------------------------------------------------------------------------------
>
> Key: FLINK-5390
> URL: https://issues.apache.org/jira/browse/FLINK-5390
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Roman Maier
> Priority: Minor
>
> {code}
> FileInputStream input = new FileInputStream(fp);
> ObjectInputStream obInput = new ObjectInputStream(input);
> jg = (JobGraph) obInput.readObject();
> input.close();
> {code}
> If readObject() throws exception, input would be left unclosed.
> Similar issue is in AbstractYarnClusterDescriptor#startAppMaster() around
> line 726.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
