[ 
https://issues.apache.org/jira/browse/FLINK-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780140#comment-15780140
 ] 

ASF GitHub Bot commented on FLINK-5368:
---------------------------------------

GitHub user HungUnicorn reopened a pull request:

    https://github.com/apache/flink/pull/3036

    [FLINK-5368] Throw exception if kafka topic doesn't exist

    As a developer when reading data from many topics, I want Kafka consumer to 
show something if any topic is not available. 
    
    The motivation is we read many topics as list at one time, and sometimes we 
fail to recognize that one or two topics' names have been changed or 
deprecated, and Flink Kafka connector didn't show the error.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HungUnicorn/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3036.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3036
    
----
commit b632edead770fd8386a65b6f67c739ad9c280a7c
Author: HungUnicorn <[email protected]>
Date:   2016-12-27T10:37:30Z

    [FLINK-5368] log msg if kafka topic doesn't have any partitions

----


> Let Kafka consumer show something when it fails to read one topic out of 
> topic list
> -----------------------------------------------------------------------------------
>
>                 Key: FLINK-5368
>                 URL: https://issues.apache.org/jira/browse/FLINK-5368
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>            Reporter: Sendoh
>            Assignee: Sendoh
>            Priority: Critical
>
> As a developer when reading data from many topics, I want Kafka consumer to 
> show something if any topic is not available. The motivation is we read many 
> topics as list at one time, and sometimes we fail to recognize that one or 
> two topics' names have been changed or deprecated, and Flink Kafka connector 
> doesn't show the error.
> My proposed change would be either to throw RuntimeException or to use 
> LOG.error(topic + "doesn't have any partition") if partitionsForTopic is null 
> at this function. 
> https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer09.java#L208
> Any suggestion is welcome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to