gustavodemorais commented on code in PR #26600:
URL: https://github.com/apache/flink/pull/26600#discussion_r2109122212
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/process/AbstractProcessTableOperator.java:
##########
@@ -322,14 +315,18 @@ private void setTimeContext() {
}
private void setCollectors() {
- if (tableSemantics == null || tableSemantics.passColumnsThrough()) {
- evalCollector = new PassAllCollector(output, changelogMode);
+ final int tableCount = tableSemantics.size();
+ if (tableCount == 0
+ ||
tableSemantics.stream().anyMatch(RuntimeTableSemantics::passColumnsThrough)) {
+ assert tableCount <= 1;
+ // Collect with all input columns (potentially none)
+ evalCollector = new PassAllCollector(output, changelogMode, 1);
} else {
- evalCollector =
- new PassPartitionKeysCollector(
- output, changelogMode,
tableSemantics.partitionByColumns());
+ // Collect with partition keys for each table
+ evalCollector = new PassPartitionKeysCollector(output,
changelogMode, tableSemantics);
}
- onTimerCollector = new PassAllCollector(output, changelogMode);
+ // Collect with partition keys for each table
Review Comment:
nit: is this comment correct? Seems to be the same for
PassPartitionKeysCollector which collects with the partition key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
