davidradl commented on code in PR #26594:
URL: https://github.com/apache/flink/pull/26594#discussion_r2110174177
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/writer/AbstractBinaryWriter.java:
##########
@@ -165,8 +165,11 @@ public void writeDecimal(int pos, DecimalData value, int
precision) {
assert value == null || (value.precision() == precision);
if (DecimalData.isCompact(precision)) {
- assert value != null;
- writeLong(pos, value.toUnscaledLong());
+ if (value == null) {
+ setNullBit(pos);
Review Comment:
why is this `setNullBit(pos); `but all the others are `setNullAt(pos);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
