xishuaidelin commented on code in PR #26616:
URL: https://github.com/apache/flink/pull/26616#discussion_r2122774679
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java:
##########
@@ -374,6 +374,15 @@ public class ExecutionConfigOptions {
// ------------------------------------------------------------------------
// Async Lookup Options
// ------------------------------------------------------------------------
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<Boolean>
TABLE_EXEC_ASYNC_LOOKUP_KEY_ORDERED =
+ key("table.exec.async-lookup.key-ordered-enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "When true async lookup joins would follow the
upsert key order in cdc stream (if no upsert key, "
Review Comment:
Hi, @davidradl . Sorry for my late reply and thanks for your good catch
here.
This optimization is not applicable to insert-only streams, as each record
in such streams is independent and does not affect the state of previous
records. Moreover, since these records typically do not involve a primary key,
no upsertKey can be derived. As a result, processing them in an unordered mode
has no difference with processing them in key-ordered mode.
I would clarify this in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
