georgelza commented on PR #22: URL: https://github.com/apache/flink-connector-prometheus/pull/22#issuecomment-2940352567
Hi Darren Is sink.batch.max-size and sink.flush-buffer.size part of the current build. I noticed metric.name needs to map to a column in the table, I will argue that this is not desirable... you might have multiple tables being that will push to the prometheus store. based on the table being used the user will want to define a text string as the name of the metrics contained... G On Wed, Jun 4, 2025 at 9:57 AM darenwkt ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > flink-connector-prometheus-request-signer-amp/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AmazonManagedPrometheusWriteRequestSignerFactory.java > <https://github.com/apache/flink-connector-prometheus/pull/22#discussion_r2125943268> > : > > > @@ -0,0 +1,36 @@ > +package org.apache.flink.connector.prometheus.sink.aws; > + > +import org.apache.flink.connector.prometheus.sink.PrometheusRequestSigner; > +import org.apache.flink.connector.prometheus.table.PrometheusConfig; > +import org.apache.flink.connector.prometheus.table.PrometheusDynamicRequestSignerFactory; > + > +import java.util.regex.Matcher; > +import java.util.regex.Pattern; > + > +public class AmazonManagedPrometheusWriteRequestSignerFactory > > Hi @georgelza <https://github.com/georgelza>, > > 'sink.batch.max-size' determines the max size of batch records before > flushing it to sink. I would recommend checking the asyncSink FLIP for more > details on how it works > https://cwiki.apache.org/confluence/display/FLINK/FLIP-171%3A+Async+Sink > > Another helpful resource is to check other similar connector and how these > config are used > https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/kinesis/#sink-batch-max-size > > When this PR is merged and released, we should have equivalent docs on > what each of these config mean as well > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/flink-connector-prometheus/pull/22#discussion_r2125943268>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AGZLFPZT6VNQTEBKLASEMFD3B2RFFAVCNFSM6AAAAAB2JAJHWCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQOJVGY4TINRQHE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- You have the obligation to inform one honestly of the risk, and as a person you are committed to educate yourself to the total risk in any activity! Once informed & totally aware of the risk, every fool has the right to kill or injure themselves as they see fit! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
