kgeis commented on PR #172: URL: https://github.com/apache/flink-connector-jdbc/pull/172#issuecomment-2948043720
Sorry, I didn't realize that change would have impacts elsewhere. Reviewing the code, I question the decision to have the CrateDB dialect extend the PostgreSQL. Just because they talk the same wire protocol doesn't mean their SQL or data types will be the same. For example, `CREATE TABLE T (f0 TIMESTAMP(3))` works on PostgreSQL 17 but CrateDB 5.10 complains ``` Error! SQLParseException[The 'timestamp' type doesn't support type parameters.] ``` That said, I was able to get the tests running locally (at least through the CrateDB tests), and when I updated the CrateDBDialectTest to follow the PostgreSQLDialectTest, they passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
