twalthr commented on code in PR #26638:
URL: https://github.com/apache/flink/pull/26638#discussion_r2132126772
##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/table/calcite/ExtendedRelTypeFactory.java:
##########
@@ -33,4 +35,10 @@ public interface ExtendedRelTypeFactory extends
RelDataTypeFactory {
/** Creates a RAW type such as {@code RAW('org.my.Class', 'sW3Djsds...')}.
*/
RelDataType createRawType(String className, String serializerString);
+
+ /**
+ * Creates a STRUCTURED type such as {@code STRUCTURED('org.my.Class',
name STRING, age INT)}.
+ */
+ RelDataType createStructuredType(
+ String className, List<RelDataType> typeList, List<String>
fieldNameList);
Review Comment:
Very thorough review! Yes, the comments don't end up in the planner. We do
the same for ROW. This is historical legacy that bites us until today. These
comments make comparisons and other operations unnecessary complicated. For
now, we leave them out. However, a catalog can use them already for `DESCRIBE
t`. From a type definition point of view the type is defined. Everything else
we need to solve in a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
