xishuaidelin commented on code in PR #26616:
URL: https://github.com/apache/flink/pull/26616#discussion_r2134997737


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLookupJoin.java:
##########
@@ -310,6 +314,21 @@ protected Transformation<RowData> createJoinTransformation(
         } else {
             StreamOperatorFactory<RowData> operatorFactory;
             if (isAsyncEnabled) {
+                if (asyncLookupOptions.keyOrdered) {
+                    return createKeyOrderedAsyncLookupJoin(

Review Comment:
   For batch processing, the behavior is fundamentally different. This solution 
doesn't introduce more complexity; instead, it helps to keep the code clean by 
separating concerns.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to