hlteoh37 commented on code in PR #211:
URL:
https://github.com/apache/flink-connector-aws/pull/211#discussion_r2135564931
##########
pom.xml:
##########
@@ -53,10 +53,11 @@ under the License.
</scm>
<properties>
+ <!-- TODO: Remove AWS SDK v1 -->
<aws.sdkv1.version>1.12.439</aws.sdkv1.version>
<aws.sdkv2.version>2.26.19</aws.sdkv2.version>
Review Comment:
Let's decouple the changes -we can always do that in a followup PR
##########
pom.xml:
##########
@@ -53,10 +53,11 @@ under the License.
</scm>
<properties>
+ <!-- TODO: Remove AWS SDK v1 -->
<aws.sdkv1.version>1.12.439</aws.sdkv1.version>
<aws.sdkv2.version>2.26.19</aws.sdkv2.version>
Review Comment:
Good suggestion, but let's decouple the changes -we can always do that in a
followup PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
