hlteoh37 commented on PR #203: URL: https://github.com/apache/flink-connector-aws/pull/203#issuecomment-2955644993
Hmm, I do prefer keeping E2E test as E2E with creds (testing against real services). IT case shouldn't be mixed in because we can run those locally as well (Docker env makes them pretty easily replicable). The North Star here is for us to setup testing against real services on the PR, so that contributors don't need to spend their own ££ setting up manual E2E tests. In addition, the current Github workflow on PR doesn't lend itself well to iteration, especially if tests fail on IT case. So, I'd +1 to keeping IT case in the current build. If we want to facilitate faster local testing, we can always introduce a development "helper command" in maven pom to skip IT tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
