MartijnVisser commented on code in PR #26662:
URL: https://github.com/apache/flink/pull/26662#discussion_r2141955041
##########
flink-formats/flink-avro-confluent-registry/src/main/java/org/apache/flink/formats/avro/registry/confluent/ConfluentSchemaRegistryCoder.java:
##########
@@ -58,7 +77,7 @@ public ConfluentSchemaRegistryCoder(String subject,
SchemaRegistryClient schemaR
* @param schemaRegistryClient client to connect schema registry
*/
public ConfluentSchemaRegistryCoder(SchemaRegistryClient
schemaRegistryClient) {
- this.schemaRegistryClient = schemaRegistryClient;
+ this(null, schemaRegistryClient, null);
Review Comment:
That's a valid nit, but the original commit that I took over had that
changed already and is in this PR, see
https://github.com/apache/flink/blob/0b8f50bc70db8f5eb69e92ca2cf52eb4c83a15fc/flink-formats/flink-avro-confluent-registry/src/main/java/org/apache/flink/formats/avro/registry/confluent/ConfluentSchemaRegistryCoder.java#L70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
