[
https://issues.apache.org/jira/browse/FLINK-37889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17966277#comment-17966277
]
Gustavo de Morais commented on FLINK-37889:
-------------------------------------------
That's great to hear, [~stevenpoor]. Looking forward to it.
I'm also asking because we might have some code conflicts. We're now slowly
getting to the part of the code which we'll both touch at the same time. I'm
currently working on the StreamPhysicalMultiJoinRule which converts the
FlinkLogicalMultiJoin into a StreamPhysicalMultiJoin. I've written a
FlinkLogicalMultiJoin and asked myself if you're using Calcite's native
MultiJoin or if you've also written a FlinkLogicalMultiJoin. Anyway, I'll have
some clarity when you share the draft PR, thanks.
> Add new FlinkJoinToFlinkMultiJoinRule rule
> ------------------------------------------
>
> Key: FLINK-37889
> URL: https://issues.apache.org/jira/browse/FLINK-37889
> Project: Flink
> Issue Type: Sub-task
> Reporter: Gustavo de Morais
> Priority: Major
>
> The current FlinkJoinToMultiJoinRule is implemented and only used for join
> reordering. We can use it as a base but we need a new set of optimizer rules
> for the multi way join operator. This ticket covers:
> * Add FlinkLogicalMultiJoin with all parameters we need to create it
> ** There are some parameters that calcite's MultiJoin does not contain as we
> require it. For example: we only have outerJoinConditions and we actually
> need all join conditions for each input level, including inner joins.
> Related:
> * Add right join to left join rule - our operator only works with left joins
> * Check if the join chain respects the multi join common key restrictions
> ** If not, create one multi join for each group of joins that respect. That
> means 9 chained joins, 3 have one common key and 6 have another will generate
> two chained multi joins.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
