gustavodemorais commented on PR #26689: URL: https://github.com/apache/flink/pull/26689#issuecomment-2983434155
> Hey, @gustavodemorais ! Sorry for the waiting, I was unexpectedly extremely busy last week. Please take a look at this. There will be plenty of refactoring but this version works for now with commonJoinKey checking and right joins enabled. Hey @SteveStevenpoor, I understand, sorry for the rush because of the deadline. We're far with https://github.com/apache/flink/pull/26687 and will probably merge it today or tomorrow. If you have the capacity, you could open a PR against that branch to cover mostly [FLINK-37890](https://issues.apache.org/jira/browse/FLINK-37890). It'll be automatically retargeted to master as soon as we merge https://github.com/apache/flink/pull/26687. Some observations from reviewing this PR: - No commonJoinKey in general does not mean we don't use MultiJoin, it just means we have to break it into multiple MultiJoins. It's in the description of FLINK-37890. testInnerJoinChainNoCommonJoinKey e.g. would have two multiple joins with two inputs each. We want a test to check if we can have for example 2, 3 MultiJoins combined. - We want to use calcilte's MultiJoin for now in the rule to be able to combined it with the native project and merge rule for now, as we did in the other PR. commonJoinKeys doesn't have to be stored. We just need to check if the constraint is respected here. - The rule shouldn't cover right joins since we got the other for that. - We'd want e2e table programs to test it as shown in the other PR. If you don't have a lot of time now, that's no problem and I'll get to this probably tomorrow. After the deadline, we can discuss you picking other items for the multi way join without the rush of the deadline. We still have some essential jira tickets to get the feature from an experimental state to production ready [here](https://issues.apache.org/jira/browse/FLINK-37859). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
