snuyanzin commented on code in PR #26702:
URL: https://github.com/apache/flink/pull/26702#discussion_r2157542074
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinToMultiJoinRule.java:
##########
@@ -546,12 +557,140 @@ private boolean canCombine(
} else {
Review Comment:
nit: looks like lots of duplicated code here...
can we extract something if it is not too complicated?
i guess at least
```java
for (int joinKey : joinKeys) {
if (inputNullGenFieldList.get(joinKey + beginIndex)) {
return false;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
