SteveStevenpoor commented on code in PR #26702:
URL: https://github.com/apache/flink/pull/26702#discussion_r2158738698
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinToMultiJoinRule.java:
##########
@@ -325,14 +328,7 @@ private List<RelNode> combineInputs(
joinFieldRefCountsList.add(new
int[left.getRowType().getFieldCount()]);
}
- if (canCombine(
- right,
- rightKeys,
- join.getJoinType(),
- join.getJoinType().generatesNullsOnRight(),
- false,
- inputNullGenFieldList,
- left.getRowType().getFieldCount())) {
+ if (canCombine(right, join,
join.getJoinType().generatesNullsOnRight())) {
Review Comment:
It will, when RightToLeftJoinRule will switch inputs. So we can't ignore
right side. I can delete it for now and return later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
