[ 
https://issues.apache.org/jira/browse/FLINK-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15801767#comment-15801767
 ] 

ASF GitHub Bot commented on FLINK-3150:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3056#discussion_r94798020
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
 ---
    @@ -347,43 +351,88 @@ public static String getTaskManagerShellCommand(
                        boolean hasKrb5,
                        Class<?> mainClass) {
    --- End diff --
    
    There were some subtle differences in the memory setup (is that really 
intended?)), log and config directories and files which is why I did not 
generalise the setup.
    It may be done, however... question is whether it is easier to grasp 
afterwards. Or let's worry about this when there are three setups of this kind 
;)


> Make YARN container invocation configurable
> -------------------------------------------
>
>                 Key: FLINK-3150
>                 URL: https://issues.apache.org/jira/browse/FLINK-3150
>             Project: Flink
>          Issue Type: Improvement
>          Components: YARN
>            Reporter: Robert Metzger
>            Assignee: Nico Kruber
>              Labels: qa
>
> Currently, the JVM invocation call of YARN containers is hardcoded.
> With this change, I would like to make the call configurable, using a string 
> such as
> "%java% %memopts% %jvmopts% ..."
> Also, we should respect the {{java.env.home}} if its set.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to