1996fanrui commented on code in PR #26712:
URL: https://github.com/apache/flink/pull/26712#discussion_r2166012309
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateSizeEstimates.java:
##########
@@ -55,8 +54,9 @@ public Optional<Long> estimate(ExecutionVertexID jobVertexId)
{
}
public static StateSizeEstimates fromGraphAndState(
- @NotNull final ExecutionGraph executionGraph,
- @NotNull final CompletedCheckpoint latestCheckpoint) {
+ final ExecutionGraph executionGraph, final CompletedCheckpoint
latestCheckpoint) {
+ Objects.requireNonNull(executionGraph);
+ Objects.requireNonNull(latestCheckpoint);
Review Comment:
May I know why do we need this non-test change?
Also, the Flink community prefers to put Independent Changes in different
commits [1]. The commit message is `Extract LocalRecoverTest to reduce
AdaptiveSchedulerTest length, restore checkstyle line-length limit`, IIUC, this
change is not related to this commit message. It would be better to have a
separate commit if this change is needed.
[1]
https://flink.apache.org/how-to-contribute/code-style-and-quality-pull-requests/#3-separate-refactoring-cleanup-and-independent-changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
