[
https://issues.apache.org/jira/browse/FLINK-5391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802278#comment-15802278
]
Stephan Ewen commented on FLINK-5391:
-------------------------------------
I think the access in that method is okay, there is nothing really won by
synchronizing a single boolean read. The boolean should be volatile, though.
What is correct is that the access in {{getRunningJobsRegistry()}} should be
synchronized as it accesses both the boolean and another field.
> Unprotected access to shutdown in AbstractNonHaServices#checkNotShutdown()
> --------------------------------------------------------------------------
>
> Key: FLINK-5391
> URL: https://issues.apache.org/jira/browse/FLINK-5391
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> {code}
> private void checkNotShutdown() {
> checkState(!shutdown, "high availability services are shut down");
> {code}
> Access to shutdown is protected by lock in other places.
> The code above should protect with lock as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
