[ 
https://issues.apache.org/jira/browse/FLINK-38034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17987887#comment-17987887
 ] 

Etienne Chauchot commented on FLINK-38034:
------------------------------------------

[~poorvank] Actually, we will copy the class to cassandra module to avoid 
making any change to Flink common in case some ongoing connector development 
uses it during the old sink deprecation time. It makes sense that this task in 
a subtask of the migration to 2.1 as discussed. So I reassigned to you

> raise back the visibility of 
> org.apache.flink.streaming.runtime.operators.GenericWriteAheadSinkTest to 
> public
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-38034
>                 URL: https://issues.apache.org/jira/browse/FLINK-38034
>             Project: Flink
>          Issue Type: Technical Debt
>            Reporter: Etienne Chauchot
>            Assignee: Etienne Chauchot
>            Priority: Major
>
> The test class 
> org.apache.flink.streaming.runtime.operators.WriteAheadSinkTestBase 
> visibility was reduced as part of [junit 5 
> migration|https://issues.apache.org/jira/browse/FLINK-25544] in commit 
> 62f44e0118539c1ed0dedf47099326f97c9d0427 released in Flink 1.20. This class 
> is used for testing sink connectors. Among all the connectors listed in the 
> documentation, only Cassandra connector uses it. 
> The reduced visibility of this class prevents from testing Cassandra 
> connector against Flink 1.20 as pointed out in [this 
> PR|https://github.com/apache/flink-connector-cassandra/pull/29] and as a 
> consequence, blocks the migration of the connector to Flink 2.10. Indeed, 
> even though this class is used for testing sinks that will be replaced with 
> [sink v2|https://issues.apache.org/jira/browse/FLINK-37984], we still need to 
> test the "legacy" sinks during all the deprecation period.
> So we should raise back the visibility of this class.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to