codenohup commented on PR #45: URL: https://github.com/apache/flink-agents/pull/45#issuecomment-3034690856
> Hi @wenjin272 @codenohup > > Thanks a lot for the review! I addressed your comments and fixed failed tests. > > As suggested by @wenjin272 , I changed checkSignature in PythonFunction to do nothing, and updated related tests. > > @codenohup > > > but I encountered a non-serializable exception with WorkflowPlan. > > Well I think it depends on which serialization style we should use for `WorkflowPlan`: Java object serialization or JSON serialization. If we want to use the Java object serialization way, we need to mark `WorkflowPlan` as `Serializable` as you suggested, but we also need to mark `Action` as `Serializable`, then `Function` also should be `Serializable`, which is a bit difficult to enforce it. So maybe it’s more reasonable to use the JSON serde as replied by @wenjin272 . > > > Should we also consider adding a context parameter to support sending events and updating state? > > This is a good idea, but as @Wenjin said I didn’t find Java implementation of the context, so it’s better to have a followup PR for it. I have a small question: Would it be possible to implement Java's serializable interface only for _WorkflowPlan_, and then within the Java serialization methods, delegate to your defined JSON-based serialization approach? This would allow us to achieve Java serialization compatibility in a straightforward way, without requiring that _Action_, _Function_, or other components themselves are Java-serializable. You can take a look at my changes to _WorkflowPlan_ in the #47 — it mainly involves implementing the _Serializable_ interface and overriding the _writeObject_ and _readObject_ methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
