xuyangzhong commented on code in PR #25826:
URL: https://github.com/apache/flink/pull/25826#discussion_r2184758185
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/FlinkPruneEmptyRulesTest.scala:
##########
@@ -46,9 +46,20 @@ class FlinkPruneEmptyRulesTest extends TableTestBase {
FlinkSubQueryRemoveRule.FILTER,
CoreRules.FILTER_REDUCE_EXPRESSIONS,
CoreRules.PROJECT_REDUCE_EXPRESSIONS,
- PruneEmptyRules.FILTER_INSTANCE,
+ CoreRules.FILTER_SET_OP_TRANSPOSE,
+ CoreRules.FILTER_PROJECT_TRANSPOSE,
+ CoreRules.PROJECT_MERGE,
+ CoreRules.PROJECT_FILTER_VALUES_MERGE,
+ PruneEmptyRules.UNION_INSTANCE,
Review Comment:
Should we use `FlinkPruneEmptyRules.UNION_INSTANCE`?
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/FlinkPruneEmptyRulesTest.scala:
##########
@@ -46,9 +46,20 @@ class FlinkPruneEmptyRulesTest extends TableTestBase {
FlinkSubQueryRemoveRule.FILTER,
CoreRules.FILTER_REDUCE_EXPRESSIONS,
CoreRules.PROJECT_REDUCE_EXPRESSIONS,
- PruneEmptyRules.FILTER_INSTANCE,
+ CoreRules.FILTER_SET_OP_TRANSPOSE,
+ CoreRules.FILTER_PROJECT_TRANSPOSE,
+ CoreRules.PROJECT_MERGE,
+ CoreRules.PROJECT_FILTER_VALUES_MERGE,
+ PruneEmptyRules.UNION_INSTANCE,
+ PruneEmptyRules.INTERSECT_INSTANCE,
+ PruneEmptyRules.MINUS_INSTANCE,
Review Comment:
ditto
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/FlinkPruneEmptyRulesTest.scala:
##########
@@ -46,9 +46,20 @@ class FlinkPruneEmptyRulesTest extends TableTestBase {
FlinkSubQueryRemoveRule.FILTER,
CoreRules.FILTER_REDUCE_EXPRESSIONS,
CoreRules.PROJECT_REDUCE_EXPRESSIONS,
- PruneEmptyRules.FILTER_INSTANCE,
+ CoreRules.FILTER_SET_OP_TRANSPOSE,
+ CoreRules.FILTER_PROJECT_TRANSPOSE,
+ CoreRules.PROJECT_MERGE,
+ CoreRules.PROJECT_FILTER_VALUES_MERGE,
+ PruneEmptyRules.UNION_INSTANCE,
+ PruneEmptyRules.INTERSECT_INSTANCE,
+ PruneEmptyRules.MINUS_INSTANCE,
PruneEmptyRules.PROJECT_INSTANCE,
- PruneEmptyRules.JOIN_RIGHT_INSTANCE
+ PruneEmptyRules.FILTER_INSTANCE,
+ PruneEmptyRules.SORT_INSTANCE,
+ PruneEmptyRules.AGGREGATE_INSTANCE,
+ PruneEmptyRules.JOIN_LEFT_INSTANCE,
+ PruneEmptyRules.JOIN_RIGHT_INSTANCE,
+ PruneEmptyRules.EMPTY_TABLE_INSTANCE
Review Comment:
Please add tests for `EMPTY_TABLE_INSTANCE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
