bvarghese1 commented on code in PR #26424: URL: https://github.com/apache/flink/pull/26424#discussion_r2185050135
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/OverWindowTestPrograms.java:
##########
@@ -227,141 +227,63 @@ public class OverWindowTestPrograms {
"key1",
3L,
200L,
- 4L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 5L,
- 500L,
- 6L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 5L,
- 500L,
- 9L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 6L,
- 600L,
- 12L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 6L,
- 600L,
15L),
Row.of("key2", 1L, 100L,
1L),
Row.of("key2", 2L, 200L,
3L))
.consumedAfterRestore(
Row.of("key3", 1L, 100L,
1L),
- Row.of("key1", 4L, 400L,
8L),
+ Row.of("key1", 4L, 400L,
19L),
Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 5L,
- 500L,
- 9L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 5L,
- 500L,
- 13L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 6L,
- 600L,
- 15L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 6L,
- 600L,
- 19L),
- Row.ofKind(
- RowKind.DELETE,
"key1", 3L, 200L, 4L),
+ RowKind.DELETE,
"key1", 3L, 200L, 15L),
Row.ofKind(
RowKind.UPDATE_BEFORE,
"key1",
4L,
400L,
- 8L),
+ 19L),
Row.ofKind(
RowKind.UPDATE_AFTER,
"key1",
4L,
400L,
- 5L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 5L,
- 500L,
- 13L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 5L,
- 500L,
- 10L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 6L,
- 600L,
- 19L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 6L,
- 600L,
16L),
Row.ofKind(
RowKind.UPDATE_AFTER,
"key1",
3L,
300L,
- 4L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 4L,
- 400L,
- 5L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 4L,
- 400L,
- 8L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 5L,
- 500L,
- 10L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 5L,
- 500L,
- 13L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 6L,
- 600L,
- 16L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 6L,
- 600L,
19L))
.build())
+ .runSql(
+ "INSERT INTO sink_t SELECT key, val, ts,
SUM(val) OVER ("
+ + "PARTITION BY key "
Review Comment:
Used `partition by val` and `order by key`
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/OverWindowTestPrograms.java:
##########
@@ -227,141 +227,63 @@ public class OverWindowTestPrograms {
"key1",
3L,
200L,
- 4L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 5L,
- 500L,
- 6L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 5L,
- 500L,
- 9L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 6L,
- 600L,
- 12L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 6L,
- 600L,
15L),
Row.of("key2", 1L, 100L,
1L),
Row.of("key2", 2L, 200L,
3L))
.consumedAfterRestore(
Row.of("key3", 1L, 100L,
1L),
- Row.of("key1", 4L, 400L,
8L),
+ Row.of("key1", 4L, 400L,
19L),
Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 5L,
- 500L,
- 9L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 5L,
- 500L,
- 13L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 6L,
- 600L,
- 15L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 6L,
- 600L,
- 19L),
- Row.ofKind(
- RowKind.DELETE,
"key1", 3L, 200L, 4L),
+ RowKind.DELETE,
"key1", 3L, 200L, 15L),
Row.ofKind(
RowKind.UPDATE_BEFORE,
"key1",
4L,
400L,
- 8L),
+ 19L),
Row.ofKind(
RowKind.UPDATE_AFTER,
"key1",
4L,
400L,
- 5L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 5L,
- 500L,
- 13L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 5L,
- 500L,
- 10L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 6L,
- 600L,
- 19L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 6L,
- 600L,
16L),
Row.ofKind(
RowKind.UPDATE_AFTER,
"key1",
3L,
300L,
- 4L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 4L,
- 400L,
- 5L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 4L,
- 400L,
- 8L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 5L,
- 500L,
- 10L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 5L,
- 500L,
- 13L),
- Row.ofKind(
-
RowKind.UPDATE_BEFORE,
- "key1",
- 6L,
- 600L,
- 16L),
- Row.ofKind(
-
RowKind.UPDATE_AFTER,
- "key1",
- 6L,
- 600L,
19L))
.build())
+ .runSql(
+ "INSERT INTO sink_t SELECT key, val, ts,
SUM(val) OVER ("
+ + "PARTITION BY key "
+ + "ORDER BY key "
+ + "ROWS BETWEEN UNBOUNDED
PRECEDING AND CURRENT ROW) "
Review Comment:
Added a similar test for Range
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
