gustavodemorais commented on code in PR #26768:
URL: https://github.com/apache/flink/pull/26768#discussion_r2195446357
##########
flink-runtime-web/web-dashboard/src/app/pages/job/overview/chart/job-overview-drawer-chart.component.ts:
##########
@@ -44,12 +45,13 @@ import { JobLocalService } from '../../job-local.service';
imports: [NgIf, NzSelectModule, FormsModule, NgForOf, JobChartComponent],
standalone: true
})
-export class JobOverviewDrawerChartComponent implements OnInit, OnDestroy {
+export class JobOverviewDrawerChartComponent implements OnInit, OnDestroy,
AfterViewInit {
public data = [];
public listOfMetricName: string[] = [];
public listOfSelectedMetric: string[] = [];
public listOfUnselectedMetric: string[] = [];
public cacheMetricKey: string;
+ public dropdownWidth: number = 200; // Default width
Review Comment:
Isn't the current default width 300px? Can we keep the same current default
width?
##########
flink-runtime-web/web-dashboard/src/app/pages/job/overview/chart/job-overview-drawer-chart.component.html:
##########
@@ -26,14 +26,16 @@
nzShowSearch
[nzPlaceHolder]="'Select Metric Name'"
(ngModelChange)="updateMetric($event)"
+ nzDropdownMatchSelectWidth="false"
+ [nzDropdownStyle]="{ 'min-width': dropdownWidth + 'px', 'max-width':
'80vw' }"
Review Comment:
How has priority here, min or max width? Basically, is there a chance we
overflow the parent component or are we always going to use at most 80% of the
view port of the parent component?
Could you share a small video where you add some metrics and resize the
screen, making it really small and really big so we see how it behaves?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
