RocMarshal commented on code in PR #25734:
URL: https://github.com/apache/flink/pull/25734#discussion_r2204488989
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridge.java:
##########
@@ -210,34 +223,34 @@ void newSlotsAreAvailable(Collection<? extends
PhysicalSlot> newSlots) {
return;
}
- if (slotBatchAllocatable) {
- newSlotsAvailableForSlotBatchAllocatable(newSlots);
- } else {
- newSlotsAvailableForDirectlyAllocatable(newSlots);
+ if (!slotBatchAllocatable) {
Review Comment:
Thanks @WeiZhong94 for the detailed comments.
Considering the parameter passing chain, it seems that 'deferSlotAllocation'
is better than 'slotBatchAllocatable'. Therefore, I have made naming checks and
adjustments to the code and parameter passing logic related to this parameter.
Additionally, I appended the patches that modify each comment right after
the corresponding commits, hoping this will make your review a bit easier.
Pls don’t worry, when this code reaches a mergeable state, I will squash
these extra changes into the respective formal commits.
Looking forward to your next review~.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/LoadableResourceProfile.java:
##########
Review Comment:
updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
