dianfu commented on code in PR #26798:
URL: https://github.com/apache/flink/pull/26798#discussion_r2207051407


##########
flink-python/pyflink/fn_execution/table/window_aggregate_fast.pxd:
##########
@@ -25,7 +25,7 @@ cdef class NamespaceAggsHandleFunctionBase:
     cdef void retract(self, InternalRow input_data)
     cpdef void merge(self, object namespace, list accumulators)
     cpdef void set_accumulators(self, object namespace, list accumulators)
-    cdef list get_accumulators(self)
+    cpdef list get_accumulators(self)

Review Comment:
   I don't think this is possible... The code path is already covered by 
existing tests. This case just occurs occasionally. For the exception reported 
in the JIRA, the job could run succeed after failover.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to