davidradl commented on code in PR #26799:
URL: https://github.com/apache/flink/pull/26799#discussion_r2207903278
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/DataTypeFactoryImpl.java:
##########
@@ -114,15 +111,18 @@ public <T> DataType createRawDataType(TypeInformation<T>
typeInfo) {
@Override
public LogicalType createLogicalType(String typeString) {
final LogicalType parsedType = LogicalTypeParser.parse(typeString,
classLoader);
- return parsedType.accept(resolver);
+ if (LogicalTypeChecks.hasNested(parsedType, t ->
t.is(LogicalTypeRoot.UNRESOLVED))) {
Review Comment:
@twalthr happy to do this, I wonder how I drive the exception in a realish
unit test. I see you have added "NotInClassPathPojo" to the tests which I would
think would drive the first unsupportedUserDefinedTypes() - but I don't see the
table Exception being dealt with in the existing tests. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
