Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3036#discussion_r94956342
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer09.java
---
@@ -208,13 +208,12 @@ public FlinkKafkaConsumer09(List<String> topics,
KeyedDeserializationSchema<T> d
if (partitionsForTopic != null) {
partitions.addAll(convertToFlinkKafkaTopicPartition(partitionsForTopic));
}
+ else{
+ LOG.info("Unable to retrieve any
partitions for the requested topic: {}", topic);
+ }
}
}
- if (partitions.isEmpty()) {
- throw new RuntimeException("Unable to retrieve any
partitions for the requested topics " + topics);
- }
--- End diff --
I think Robert was suggesting to log messages only for cases where _some_
topics don't have partitions, so that the consumer doesn't just fail if for
example only 1 out of 10 topics don't have partitions.
If ALL topics failed to return partitions in the end, we probably should
still fail the consumer, like before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
