[
https://issues.apache.org/jira/browse/FLINK-4692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804714#comment-15804714
]
ASF GitHub Bot commented on FLINK-4692:
---------------------------------------
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2938
Thanks for working on this @wuchong! The code looks very good. I haven"t
reviewed the code entirely but tried to verify if batch and stream queries
return the same result. Unfortunately, this is not the case at the moment.
I converted the stream test
`org.apache.flink.api.scala.stream.table.AggregationsITCase#testEventTimeTumblingWindow`
and your batch test
`org.apache.flink.api.scala.batch.table.AggregationsITCase#testEventTimeTumblingGroupWindowOverTime`
but the aggregations are different.
Could you have a look at it?
> Add tumbling group-windows for batch tables
> -------------------------------------------
>
> Key: FLINK-4692
> URL: https://issues.apache.org/jira/browse/FLINK-4692
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Jark Wu
>
> Add Tumble group-windows for batch tables as described in
> [FLIP-11|https://cwiki.apache.org/confluence/display/FLINK/FLIP-11%3A+Table+API+Stream+Aggregations].
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
