1996fanrui commented on code in PR #26831: URL: https://github.com/apache/flink/pull/26831#discussion_r2230489782
########## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/AbstractRocksDBState.java: ########## @@ -176,7 +176,10 @@ <T> byte[] serializeValueNullSensitive(T value, TypeSerializer<T> serializer) throws IOException { dataOutputView.clear(); dataOutputView.writeBoolean(value == null); - return serializeValueInternal(value, serializer); + if (value != null) { + serializer.serialize(value, dataOutputView); + } + return dataOutputView.getCopyOfBuffer(); Review Comment: Hey @rkhachatryan , I found the change log state backend is serialized in https://issues.apache.org/jira/browse/FLINK-21355 , hope to hear your opinion as well. Thank you both in advance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org