rmetzger commented on code in PR #26850:
URL: https://github.com/apache/flink/pull/26850#discussion_r2247105275
##########
flink-metrics/flink-metrics-otel/src/main/java/org/apache/flink/traces/otel/OpenTelemetryTraceReporter.java:
##########
@@ -56,10 +60,28 @@ public class OpenTelemetryTraceReporter extends
OpenTelemetryReporterBase implem
public void open(MetricConfig metricConfig) {
LOG.info("Starting OpenTelemetryTraceReporter");
super.open(metricConfig);
- OtlpGrpcSpanExporterBuilder builder = OtlpGrpcSpanExporter.builder();
- tryConfigureEndpoint(metricConfig, builder::setEndpoint);
- tryConfigureTimeout(metricConfig, builder::setTimeout);
- spanExporter = builder.build();
+
+ final String protocol =
+
metricConfig.getProperty(OpenTelemetryReporterOptions.EXPORTER_PROTOCOL.key());
+
+ if (Protocol.HTTP.name().equalsIgnoreCase(protocol)) {
+ OtlpHttpSpanExporterBuilder builder =
OtlpHttpSpanExporter.builder();
+ tryConfigureEndpoint(metricConfig, builder::setEndpoint);
+ tryConfigureTimeout(metricConfig, builder::setTimeout);
+ spanExporter = builder.build();
+ } else {
+ if (!Protocol.gRPC.name().equalsIgnoreCase(protocol)) {
+ LOG.warn(
+ "Unknown protocol '{}' for OpenTelemetryEventReporter,
defaulting to gRPC",
Review Comment:
```suggestion
"Unknown protocol '{}' for
OpenTelemetryTraceReporter, defaulting to gRPC",
```
##########
flink-metrics/flink-metrics-otel/src/main/java/org/apache/flink/metrics/otel/OpenTelemetryMetricReporter.java:
##########
@@ -92,10 +95,27 @@ public OpenTelemetryMetricReporter() {
public void open(MetricConfig metricConfig) {
LOG.info("Starting OpenTelemetryMetricReporter");
super.open(metricConfig);
- OtlpGrpcMetricExporterBuilder builder =
OtlpGrpcMetricExporter.builder();
- tryConfigureEndpoint(metricConfig, builder::setEndpoint);
- tryConfigureTimeout(metricConfig, builder::setTimeout);
- exporter = builder.build();
+
+ final String protocol =
+
metricConfig.getProperty(OpenTelemetryReporterOptions.EXPORTER_PROTOCOL.key());
+
+ if (Protocol.HTTP.name().equalsIgnoreCase(protocol)) {
+ OtlpHttpMetricExporterBuilder builder =
OtlpHttpMetricExporter.builder();
+ tryConfigureEndpoint(metricConfig, builder::setEndpoint);
+ tryConfigureTimeout(metricConfig, builder::setTimeout);
+ exporter = builder.build();
+ } else {
+ if (!Protocol.gRPC.name().equalsIgnoreCase(protocol)) {
+ LOG.warn(
+ "Unknown protocol '{}' for OpenTelemetryEventReporter,
defaulting to gRPC",
Review Comment:
```suggestion
"Unknown protocol '{}' for
OpenTelemetryMetricReporter, defaulting to gRPC",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
