wenjin272 commented on code in PR #91: URL: https://github.com/apache/flink-agents/pull/91#discussion_r2256489331
########## api/src/main/java/org/apache/flink/agents/api/Resource.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.agents.api; + +import java.io.Serializable; +import java.util.function.BiFunction; + +/** + * Base interface for all kinds of resources, including chat models, tools, prompts and so on. + * + * <p>Resources are components that can be used by agents during action execution. + */ +public interface Resource extends Serializable { Review Comment: In python implementation, there are two type of Resource: 1. Resource which is not json serializable, link ChatModel, for it may contain some fields which are not json serializable. 2. SerializableResource which is json serializable, link function tool. For Resource we construct it in runtime, and for SerializableResource we can get or deserialize it in runtime. In currently implementation, for there is no resource implementation which is not json serializable, only provide resource is enough, but for clarity of semantics, I think may be we can provide distinction at the beginning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
