raminqaf commented on code in PR #26862: URL: https://github.com/apache/flink/pull/26862#discussion_r2256284197
########## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ########## @@ -649,9 +649,9 @@ private static List<TestSetSpec> allTypesBasic() { BIGINT(), DEFAULT_POSITIVE_BIGINT, (double) DEFAULT_POSITIVE_BIGINT) .fromCase( BIGINT(), DEFAULT_NEGATIVE_BIGINT, (double) DEFAULT_NEGATIVE_BIGINT) - .fromCase(FLOAT(), DEFAULT_POSITIVE_FLOAT, 123.456d) - .fromCase(FLOAT(), DEFAULT_NEGATIVE_FLOAT, -123.456) - .fromCase(FLOAT(), 9234567891.12, 9234567891.12d) + .fromCase(FLOAT(), DEFAULT_POSITIVE_FLOAT, 123.45600128173828) + .fromCase(FLOAT(), DEFAULT_NEGATIVE_FLOAT, -123.45600128173828) + .fromCase(FLOAT(), 9234567891.12, 9.234568192E9) .fromCase(DOUBLE(), DEFAULT_POSITIVE_DOUBLE, DEFAULT_POSITIVE_DOUBLE) Review Comment: The output aligns even with the tests in CasRulesTest: https://github.com/raminqaf/flink/blob/17f3cdbc7ece39cf1866c22ba16d5976b652df35/flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/casting/CastRulesTest.java#L430-L431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org