snuyanzin commented on code in PR #26874:
URL: https://github.com/apache/flink/pull/26874#discussion_r2262576404
##########
flink-python/pyflink/table/catalog.py:
##########
@@ -1118,6 +1118,16 @@ def get_function_language(self):
"""
return self._j_catalog_function.getFunctionLanguage()
+ def get_options(self) -> Dict[str, str]:
+ """
+ Returns a map of string-based options.
+
+ :return: Property map of the function.
+
+ .. versionadded:: 2.1.0
Review Comment:
```suggestion
.. versionadded:: 2.2.0
```
nit
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogFunctionImpl.java:
##########
@@ -116,6 +138,9 @@ public String toString() {
+ "', "
+ "functionResource='"
+ getFunctionResources()
- + "'}";
+ + "', "
+ + "options='"
+ + getOptions()
+ + "'";
Review Comment:
```suggestion
+ "'}";
```
shouldn't we have a closing bracket here?
Asking since there is opening one at the very beginning like
`CatalogFunctionImpl{`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
