AmenAdem commented on code in PR #94: URL: https://github.com/apache/flink-agents/pull/94#discussion_r2271362640
########## api/src/main/java/org/apache/flink/agents/api/tool/ToolMetadata.java: ########## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.agents.api.tool; + +import java.lang.reflect.Method; +import java.util.List; +import java.util.Objects; + +/** + * Metadata for a tool including its definition, invocation method, and parameters. This class holds + * all the information needed to register and invoke a tool. + */ +public class ToolMetadata { + + private final ToolDefinition definition; + private final ToolType type; + private final Method method; + private final Object instance; + private final List<ToolParameterInfo> parameters; Review Comment: You re absolutely right the inputSchema in ToolDefinition should be sufficient. I added the parameters field because I was thinking about runtime performance optimization. my reasoning was: Avoiding repeated JSON schema parsing - the List<ToolParameterInfo> would be pre-parsed parameter metadata for faster runtime access -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
