twalthr commented on code in PR #26899:
URL: https://github.com/apache/flink/pull/26899#discussion_r2272471858
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/ProcessTableFunctionSemanticTests.java:
##########
@@ -26,6 +27,11 @@
/** Semantic tests for {@link StreamExecProcessTableFunction}. */
public class ProcessTableFunctionSemanticTests extends SemanticTestBase {
+ // TODO [FLINK-38233]: Remove this override when PTF support in
+ // StreamNonDeterministicUpdatePlanVisitor is added.
+ @Override
+ protected void applyDefaultEnvironmentOptions(TableConfig config) {}
Review Comment:
do we need both the change in TableTestPrograms and this method? shouldn't a
change here be enough? We also don't need to erase everything coming from the
upper class, but only override
`OptimizerConfigOptions.TABLE_OPTIMIZER_NONDETERMINISTIC_UPDATE_STRATEGY` but
defer to `super` otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
