davidradl commented on code in PR #26892: URL: https://github.com/apache/flink/pull/26892#discussion_r2273504974
########## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/AggregateITCase.scala: ########## @@ -2119,6 +2119,242 @@ class AggregateITCase( tEnv.dropTemporarySystemFunction("PERCENTILE") } + + @TestTemplate + def testLastValueInSeparatedRow(): Unit = { + val empsData = List( + ( + 100L, + "Fred", + 10, + null, + null, + 40L, + 25, + true, + false, + ("extra1", 1), + Array("item1", "item2"), + Map("key1" -> "value1")), + ( + 100L, + "Eric", + 20, + "M", + "San Francisco", + 3L, + 80, + null, + false, + ("extra2", 2), + Array("item3", "item4"), + Map("key2" -> "value2")), + ( + 120L, + "John", + 40, + "M", + "Vancouver", + 2L, + null, + false, + true, + ("extra3", 3), + Array("item5"), + Map("key3" -> "value3")), + ( + 120L, + "Wilma", + 20, + "F", + null, + 1L, + 5, + null, + true, + ("extra4", 4), + Array("item6"), + Map("key4" -> "value4")), + ( + 120L, + "Alice", + 40, + "F", + "Vancouver", + 2L, + null, + false, + true, + ("extra5", 5), + Array("item7", "item8"), + Map("key5" -> "value5")) + ) + + val t = failingDataSource(empsData) + .toTable( + tEnv, + 'empno, + 'name, + 'deptno, + 'gender, + 'city, + 'empid, + 'age, + 'slacker, + 'manager, + 'extra_row, Review Comment: I wonder if we can test deeper nesting under the row including a row with arrays of rows of maps. Also if Variants and structured data types can be nested we should include them in the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org