Frawless commented on code in PR #26869:
URL: https://github.com/apache/flink/pull/26869#discussion_r2273913024


##########
tools/ci/google-mirror-settings.xml:
##########
@@ -25,4 +25,31 @@ under the License.
       <mirrorOf>central</mirrorOf>
     </mirror>
   </mirrors>
+
+    <!-- Fallback to central repository config for BOMs that are not part of 
google, redhat, jboss mirrors -->

Review Comment:
   1 - the problem is that google maven mirror doesn't have 5.13.x junit 
packages - mirror is not working properly (junit 5.13.0 was release in May, I 
wonder if anybody didn't hit any issues and reported it)? So it won't work.
   2 - I am not sure how. Excluding junit from commons-lang3 doesn't work as 
the bom is always downloaded. Maybe exclude it somehow in profile's build 
config?
   3 - `circumvention` I am not sure what does it mean



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to