wenjin272 commented on code in PR #110:
URL: https://github.com/apache/flink-agents/pull/110#discussion_r2278472496
##########
runtime/src/main/java/org/apache/flink/agents/runtime/memory/MemoryObjectImpl.java:
##########
@@ -197,23 +207,26 @@ private void fillParents(String[] parts) throws Exception
{
}
/** Represents an item (nested object or primitive value) stored in the
short-term memory. */
- public static final class MemoryItem {
+ public static final class MemoryItem implements Serializable {
private final ItemType type;
private final Object value;
private final Set<String> subKeys;
+ private final String typeName;
Review Comment:
Why we need `typeName`, I can't find the usage.
##########
python/flink_agents/api/memory_object.py:
##########
@@ -30,25 +32,27 @@ class MemoryObject(BaseModel, ABC):
"""
@abstractmethod
- def get(self, path: str) -> Any:
- """Get the value of a (direct or indirect) field in the object.
+ def get(self, path: Union[str,"MemoryRef"] ) -> Any:
Review Comment:
parameter name is not consistent with doc string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
