snuyanzin commented on code in PR #26584:
URL: https://github.com/apache/flink/pull/26584#discussion_r2279808834
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java:
##########
@@ -87,6 +89,9 @@ public static String buildShowCreateTableRow(
String.format(
"SHOW CREATE TABLE is only supported for tables,
but %s is a view. Please use SHOW CREATE VIEW instead.",
tableIdentifier.asSerializableString()));
+ } else if (table.getTableKind() ==
CatalogBaseTable.TableKind.MATERIALIZED_TABLE) {
Review Comment:
it will be executed from `ShowCreateTable` which is wrong
Moreover header's javadoc for `ShowCreateTable` says that that class is only
for `SHOW CREATE TABLE`
At the same time the PR added logic for `SHOW CREATE MATERIALIZED TABLE` it
should be completely another class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
