[ 
https://issues.apache.org/jira/browse/FLINK-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812337#comment-15812337
 ] 

ASF GitHub Bot commented on FLINK-5395:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3049#discussion_r95203611
  
    --- Diff: tools/create_release_files.sh ---
    @@ -201,19 +262,34 @@ prepare
     
     make_source_release
     
    -make_binary_release "hadoop2" "" 2.10
    -make_binary_release "hadoop24" "-Dhadoop.version=2.4.1" 2.10
    -make_binary_release "hadoop26" "-Dhadoop.version=2.6.3" 2.10
    -make_binary_release "hadoop27" "-Dhadoop.version=2.7.2" 2.10
    -
    -make_binary_release "hadoop2" "" 2.11
    -make_binary_release "hadoop24" "-Dhadoop.version=2.4.1" 2.11
    -make_binary_release "hadoop26" "-Dhadoop.version=2.6.3" 2.11
    -make_binary_release "hadoop27" "-Dhadoop.version=2.7.2" 2.11
    -
    -copy_data
    -
    -deploy_to_maven
    +# build dist by input parameter of "--scala-vervion xxx --hadoop-version 
xxx"
    +if [ "$scalaV" == "none" ] && [ "$hadoopV" == "none" ]; then
    +  make_binary_release "hadoop2" "" 2.10
    +  make_binary_release "hadoop24" "-Dhadoop.version=2.4.1" 2.10
    +  make_binary_release "hadoop26" "-Dhadoop.version=2.6.3" 2.10
    +  make_binary_release "hadoop27" "-Dhadoop.version=2.7.2" 2.10
    +
    +  make_binary_release "hadoop2" "" 2.11
    +  make_binary_release "hadoop24" "-Dhadoop.version=2.4.1" 2.11
    +  make_binary_release "hadoop26" "-Dhadoop.version=2.6.3" 2.11
    +  make_binary_release "hadoop27" "-Dhadoop.version=2.7.2" 2.11
    +elif [ "$scalaV" == none ] && [ "$hadoopV" != "none" ]
    --- End diff --
    
    Can we add the `"..."` for all strings to have it consistent?


> support locally build distribution by script create_release_files.sh
> --------------------------------------------------------------------
>
>                 Key: FLINK-5395
>                 URL: https://issues.apache.org/jira/browse/FLINK-5395
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: shijinkui
>
> create_release_files.sh is build flink release only. It's hard to build 
> custom local Flink release distribution.
> Let create_release_files.sh support:
> 1. custom git repo url
> 2. custom build special scala and hadoop version
> 3. add `tools/flink` to .gitignore
> 4. add usage



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to