gyfora commented on code in PR #1013:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1013#discussion_r2284581243
##########
examples/kubernetes-client-examples/src/main/java/org/apache/flink/examples/Basic.java:
##########
@@ -49,7 +50,7 @@ public static void main(String[] args) {
flinkDeploymentSpec.setImage("flink:1.19");
Map<String, String> flinkConfiguration =
Map.ofEntries(entry("taskmanager.numberOfTaskSlots", "2"));
- flinkDeploymentSpec.setFlinkConfiguration(flinkConfiguration);
+
flinkDeploymentSpec.setFlinkConfiguration(toJsonNode(flinkConfiguration));
Review Comment:
Can we provide a `setFlinkConfiguration(Map<String, String> map)` method
like before to avoid the code changes everywhere? We can mark it deprecated but
seems useful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
