gaborgsomogyi commented on code in PR #26931: URL: https://github.com/apache/flink/pull/26931#discussion_r2290958483
########## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/TaskStateAssignment.java: ########## @@ -204,15 +266,16 @@ public OperatorSubtaskState getSubtaskState(OperatorInstanceID instanceID) { return assignment.getInputMapping(assignmentIndex, recompute); }, outputSubtaskMappings, - this::getOutputMapping)) + this::getOutputMapping, + false)) .build(); } public boolean hasUpstreamOutputStates() { if (hasUpstreamOutputStates == null) { hasUpstreamOutputStates = Arrays.stream(getUpstreamAssignments()) Review Comment: This issue/risk is not introduced here but maybe we could add a check while we're hanging around here. Namely `getUpstreamAssignments` is depending on `executionJobVertex.getInputs()` which is nullable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org