rkhachatryan commented on code in PR #26938:
URL: https://github.com/apache/flink/pull/26938#discussion_r2303279253


##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointRescaleWithMixedExchangesITCase.java:
##########
@@ -230,7 +230,7 @@ private static JobClient 
createMultiInputDAG(StreamExecutionEnvironment env) thr
 
         sourceStream1
                 .rebalance()
-                .connect(forwardedStream)
+                .connect(forwardedStream.rebalance())

Review Comment:
   It looks like using FORWARD was the intention behind `forwardedStream`:
   ```
           // Keep the same parallelism to ensure the ForwardPartitioner will 
be used.
   ```
   
   But now we want to avoid FORWARD in any case, right?
   Would it make sense to rename the variable, change the comment, and add 
`rebalance` earlier?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to