fapaul commented on code in PR #26952:
URL: https://github.com/apache/flink/pull/26952#discussion_r2316060235


##########
flink-libraries/flink-state-processing-api/pom.xml:
##########
@@ -114,6 +114,13 @@ under the License.
                        <scope>test</scope>
                </dependency>
 
+               <dependency>

Review Comment:
   I agree with @davidradl in the general statement that we should not remove 
test cases that verify behavior of the "old" source. 
   For the test cases in this PR it looks like it's only replacing a test util 
that was relying on the old source but doesn't verify any behavior of the 
source itself so it should be safe to replace. 
   @davidradl please correct me if I am missing something here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to